[ganu] Week 5 #845
Open
[ganu] Week 5 #845
+193
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HC-kang
reviewed
Jan 9, 2025
There was a problem hiding this comment.
@gwbaik9717 님, 5주차도 고생하셨습니다.
아직 Solving 중이셔서 우선 코멘트만 남깁니다!
워낙 잘 작성해주셔서 코멘트 남기기가 민망하네요..ㅎㅎ
앞으로도 좋은 코드 많이 공유 부탁드려요~
| ); | ||
|
|
||
| for (const chr of str) { | ||
| const index = chr.charCodeAt() - "a".charCodeAt(); |
There was a problem hiding this comment.
중요하지 않은 사항입니다.
"a".charCodeAt()를 변수로 먼저 빼두는것도 좋지 않을까 싶네요!
| Trie.prototype.search = function (word) { | ||
| let current = this.head; | ||
|
|
||
| for (const chr of word) { |
There was a problem hiding this comment.
이것도 중요한 사항은 아닙니다!
search와 startsWith가 완전히 동일한 로직을 공유하는것 같아서, 다른 메서드로 묶어주는것도 좋을것 같네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.